fix: Do not crash due to unavailable tracks in queue #1656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash that occurs when the queue has unavailable tracks by safely handling arithmetic operations in the status bar rendering logic.
- Replace unchecked arithmetic with safe multiplication and division for computing the progress bar width.
- Update the changelog to document the crash fix.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ui/statusbar.rs | Uses checked arithmetic to prevent integer overflows in progress bar calculation. |
| CHANGELOG.md | Adds an entry to document the crash fix. |
Comments suppressed due to low confidence (1)
src/ui/statusbar.rs:193
- [nitpick] Consider adding a brief comment explaining the use of checked multiplication/division and the fallback behavior (using unwrap_or(0)) to aid future maintainers in understanding why silent failure is acceptable in this context.
let duration_width = elapsed_ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1616
Describe your changes
Issue ticket number and link
Checklist before requesting a review
not performance improvements, etc.)