-
Notifications
You must be signed in to change notification settings - Fork 20
Fix broken link in README #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link in README #381
Conversation
Both http and https immediately resolve for me, but it appears that the www is now needed. |
@shorowit @nelsonauner Thanks for bringing this up. I can confirm that as of last week it wasn't working as you described. Glad to see it's up again. |
@nmerket You closed this pull request, but the current If per @shorowit 's suggestion you'd rather have |
Oh I see. Yeah, let's change that to www.hpxmlonline.com. Thanks again. |
ok! @nmerket I took your and scotts comment to mean that you preferred to fix issue this issue by specifying subdomain ( I really love y'alls work and would be happy to help draft a |
@nmerket The link under About also needs to be updated: |
Good catch Scott! LMK if anything else I should do (e.g. rebase into a single commit before merge) |
You're good. I'll take it from here. Thank for pointing this out. |
First, thanks for supporting these fantastic tools!
When perusing documentation I noticed a broken link in the README.
http://hpxmlonline.com
is broken because the server is set to reject non-HTTPS requests instead of redirecting them.So, a user clicking this link in the readme will, for most browsers, wait 30 seconds and then receive a time out error.
The best way to fix this is to add logic to your webserver to redirect non-secure requests to HTTPS, but changing the links is also useful.
Note that I have not changed any of the non-secure links in the XML namespace (e.g.
<HPXML xmlns="https://hpxmlonline.com/2019/10" schemaVersion="3.1">
because these uses are just namespaces, not actual resolveable URLs, and are sensitive to the protocol (e.g.http
vshttps
)https://stackoverflow.com/questions/30707609/xml-namespace-uri-with-https