8000 Fix broken link in README by nelsonauner · Pull Request #381 · hpxmlwg/hpxml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix broken link in README #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

nelsonauner
Copy link
Contributor

First, thanks for supporting these fantastic tools!

When perusing documentation I noticed a broken link in the README.
http://hpxmlonline.com is broken because the server is set to reject non-HTTPS requests instead of redirecting them.
So, a user clicking this link in the readme will, for most browsers, wait 30 seconds and then receive a time out error.

The best way to fix this is to add logic to your webserver to redirect non-secure requests to HTTPS, but changing the links is also useful.

Note that I have not changed any of the non-secure links in the XML namespace (e.g. <HPXML xmlns="https://hpxmlonline.com/2019/10" schemaVersion="3.1"> because these uses are just namespaces, not actual resolveable URLs, and are sensitive to the protocol (e.g. http vs https)

https://stackoverflow.com/questions/30707609/xml-namespace-uri-with-https

@nelsonauner nelsonauner changed the title Update README.rst to HTTPS doc link Fix broken link in README Apr 10, 2023
@nelsonauner
Copy link
Contributor Author

@nmerket @shorowit I didn't see a CONTRIBUTING.md or anything on how to contribute so gave it my best shot :)

@shorowit
Copy link
Contributor

Both http and https immediately resolve for me, but it appears that the www is now needed.

http://www.hpxmlonline.com
https://www.hpxmlonline.com

@nmerket
Copy link
Contributor
nmerket commented Apr 11, 2023

@shorowit @nelsonauner Thanks for bringing this up. I can confirm that as of last week it wasn't working as you described. Glad to see it's up again.

@nmerket nmerket closed this Apr 11, 2023
@nelsonauner
Copy link
Contributor Author

@nmerket You closed this pull request, but the current master branch is broken, in that https://github.com/hpxmlwg/hpxml/blame/master/README.rst has a link to http://hpxmlonline.com and that link does not resolve.

If per @shorowit 's suggestion you'd rather have http://www.hpxmlonline.com instead https, that's fine, and I'm happy to change the PR! But there is something broken currently

@nmerket
Copy link
Contributor
nmerket commented Apr 11, 2023

Oh I see. Yeah, let's change that to www.hpxmlonline.com. Thanks again.

@nmerket nmerket reopened this Apr 11, 2023
@nelsonauner
Copy link
Contributor Author

ok! @nmerket

I took your and scotts comment to mean that you preferred to fix issue this issue by specifying subdomain (www) and keeping non-secure scheme (http://) over https://.

I really love y'alls work and would be happy to help draft a CONTRIBUTING.md or whatever to minimize annoying drive-bys like this one. LMK!

@shorowit
Copy link
Contributor

@nmerket The link under About also needs to be updated:

image

@nelsonauner
Copy link
Contributor Author

Good catch Scott!

LMK if anything else I should do (e.g. rebase into a single commit before merge)

@nmerket
Copy link
Contributor
nmerket commented Apr 12, 2023

You're good. I'll take it from here. Thank for pointing this out.

@nmerket nmerket merged commit be76e32 into hpxmlwg:master Apr 13, 2023
@nelsonauner nelsonauner deleted the nea-fix-doc-link-in-readme branch April 14, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0