8000 Buried ducts by shorowit · Pull Request #376 · hpxmlwg/hpxml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Buried ducts #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 11, 2023
Merged

Buried ducts #376

merged 16 commits into from
Jul 11, 2023

Conversation

shorowit
Copy link
Contributor
@shorowit shorowit commented Mar 14, 2023

image

New DuctBuriedInsulationLevel element with choices of:

  • not buried
  • partially buried
  • fully buried
  • deeply buried

Description of element: "Describes ducts buried in, e.g., attic loose-fill insulation. Partially buried ducts have insulation that does not cover the top of the ducts. Fully buried ducts have insulation that just covers the top of the ducts. Deeply buried ducts have insulation that continues above the top of the ducts. See https://basc.pnnl.gov/resource-guides/ducts-buried-attic-insulation for more information."

Also:

  • Updates DuctInsulationRValue description: "This should exclude the exterior air film -- e.g., use zero for uninsulated ducts. For ducts buried in insulation, this should only represent any surrounding insulation duct wrap and not the entire attic insulation R-value."
  • Adds a DuctEffectiveRValue element with description: "The overall effective R-value. Includes the exterior air film as well as other effects such as adjustments for insulation wrapped around round ducts, or ducts buried in attic insulation."

Closes #374.

@shorowit shorowit self-assigned this Mar 14, 2023
@shorowit shorowit changed the title Duct insulation Location Duct Insulation Location Mar 14, 2023
@shorowit
Copy link
Contributor Author
  • Reformulate to be more specific to buried duct scenario. Could be multiple inputs (presence, how deep, etc.).

@nmerket
Copy link
Contributor
nmerket commented Mar 15, 2023

Sorry, something went wrong.

@shorowit shorowit marked this pull request as draft April 11, 2023 16:25
@shorowit shorowit changed the title Duct Insulation Location Buried ducts Apr 13, 2023
@shorowit shorowit marked this pull request as ready for review April 13, 2023 15:23
@nmerket
Copy link
Contributor
nmerket commented May 12, 2023

@nmerket nmerket added the merge label Jun 13, 2023
@nmerket
Copy link
Contributor
nmerket commented Jun 21, 2023

@nmerket nmerket merged commit 132964c into master Jul 11, 2023
@nmerket nmerket deleted the duct_insulation_location branch July 11, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow describing buried ducts
2 participants
0