-
Notifications
You must be signed in to change notification settings - Fork 20
Expand Building/Site
#301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Building/Site
#301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From @charliepnnl, add a lat/lon element for geolocation. Add Google Place ID and UBID as well. Make a GeoLocation element for these to live in.
|
Add |
|
I believe all review comments have been addressed. The PR description has been updated. |
|
@nmerket to add documentation around google place id. |
| <xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns="http://hpxmlonline.com/2019/10" targetNamespace="http://hpxmlonline.com/2019/10" elementFormDefault="qualified" version="3.0"> | ||
| <xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns="http://hpxmlonline.com/2019/10" | ||
| targetNamespace="http://hpxmlonline.com/2019/10" elementFormDefault="qualified" version="3.0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmerket Did you intend to reformat the entire document? 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I did not. I think that was Oxygen XML trying to be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I redid the formatting to remove all the extra stuff, but kept it for a few things I thought would be helpful, like to remove extra </element> tags when they're not necessary.
GeoLocationelement, withLatitude,Longitude,PlusCode,UBID, andextensionchildreneGridRegionenumeration choiceeGridSubregionelementCambiumRegionGEAelement (closes Add Cambium GEA element #300)TimeZoneelement, withName,Abbreviation,UTCOffset,DSTObserved, andextensionchildren