Requires AssemblyEffectiveRValue to be > 0 #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2021
|
Technically this is a breaking change, but it's relatively minor and has a desired outcome of restricting the values to be realistic, which for most of the known users of HPXML v3 is actually a good thing. So, we're thinking this should go in v3.1 anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
AssemblyEffectiveRValuefrom minInclusive=0 to minExclusive=0. The R-values associated with insulation materials are unchanged (i.e., they can still be zero).An assembly effective R-value, which is documented as including air films, can never be zero. This change is proposed to prevent software tools from potentially incorrectly using a value of zero. This change helps to ensure that all software tools consistently include air films in their value.