8000 Generalize space heater element by shorowit · Pull Request #231 · hpxmlwg/hpxml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Generalize space heater element #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 19, 2023
Merged

Generalize space heater element #231

merged 9 commits into from
Sep 19, 2023

Conversation

shorowit
Copy link
Contributor
@shorowit shorowit commented Jul 8, 2020 •
edited
Loading

Replaces PortableHeater with SpaceHeater so as to accommodate fixed (non-portable) space heaters too. Space heaters may be vented or unvented.

@shorowit shorowit self-assigned this Jul 8, 2020
@shorowit shorowit mentioned this pull request Jul 8, 2020
Closed
@shorowit shorowit added this to the v3.1 milestone Jul 16, 2020
@shorowit shorowit changed the title Fixed space heater Fixed (non-portable) space heater Sep 23, 2020
@shorowit shorowit modified the milestones: v3.1, v4.0 Mar 29, 2022
@shorowit
Copy link
Contributor Author
shorowit commented Jul 11, 2023 •
edited
Loading
  • Change PortableHeater to SpaceHeater and add Portable (boolean) sub element

@shorowit shorowit changed the title Fixed (non-portable) space heater Generalize space heater element Jul 11, 2023
@shorowit shorowit mentioned this pull request Jul 11, 2023
Closed
@nmerket
Copy link
Contributor
nmerket commented Jul 12, 2023

🎥 Discussion in HPXML Working Group Meeting 2023-07-11

@nmerket nmerket added the merge label Aug 8, 2023
@nmerket
Copy link
Contributor
nmerket commented Aug 8, 2023 •
edited by shorowit
Loading
  • Remove Portable for now in case we want to do it as enumerations as in SFA/MF Systems #240 with the RoomCoolingType.

@shorowit shorowit mentioned this pull request Aug 8, 2023
Open
@nmerket
Copy link
Contributor
nmerket commented Aug 8, 2023

🎥 Discussion in HPXML Working Group Meeting 2023-08-08

@shorowit shorowit mentioned this pull request Sep 8, 2023
Open
9 tasks
@nmerket nmerket merged commit d8cec59 into master Sep 19, 2023
@nmerket nmerket deleted the fixed_space_heater branch September 19, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
breaking change enhancement merge schemas weatherization
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shorowit @nmerket
0