8000 Percent duct leakage by shorowit · Pull Request #206 · hpxmlwg/hpxml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Percent duct leakage #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2019
Merged

Percent duct leakage #206

merged 1 commit into from
Oct 28, 2019
+8 −5

Conversation

shorowit
Copy link
Contributor

Allows duct leakage to be entered as percent of airflow.

@shorowit shorowit added this to the v3.0 milestone Oct 23, 2019
@shorowit shorowit requested a review from nmerket October 23, 2019 18:14
@lirainer
Copy link

Is it worth clarifying in the documentation that this is percent of air flow? Or is that always assumed?

@shorowit
Copy link
Contributor Author

@lirainer Can you think of any other way that percent duct leakage could be interpreted?

@lirainer
Copy link

No, I can't. I guess I'm thinking of other ambiguities such as inside/outside or total/supply. But those should be handled elsewhere.

@nmerket nmerket merged commit 2e8a6a0 into master Oct 28, 2019
@nmerket nmerket deleted the duct_leakage_percentage branch October 28, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerket nmerket nmerket approved these changes

Assignees
No one assigned
Labels
enhancement home energy score schemas
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shorowit @lirainer @nmerket
0