8000 Additional AdjacentTo enumerations by shorowit · Pull Request #203 · hpxmlwg/hpxml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Additional AdjacentTo enumerations #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2019
Merged

Additional AdjacentTo enumerations #203

merged 1 commit into from
Oct 23, 2019

Conversation

shorowit
Copy link
Contributor

Adds "other housing unit above" and "other housing unit below" enumerations for AdjacentTo. The "other housing unit" enumeration is still available.

Usually you can infer whether a FrameFloor is actually a ceiling or floor surface. For example:

  • A FrameFloor with InteriorAdjacentTo="living space" and ExteriorAdjacentTo="attic - vented" is clearly a ceiling below the attic
  • A FrameFloor with InteriorAdjacentTo="living space" and ExteriorAdjacentTo="basement - unconditioned" is clearly a floor above a basement

But if you have a FrameFloor with InteriorAdjacentTo="living space" and ExteriorAdjacentTo="other housing unit" it is impossible to infer. With this change, you can clarify the ExteriorAdjacentTo as either "other housing unit above" (i.e., ceiling) or "other housing unit below" (i.e., floor).

@shorowit shorowit added this to the v3.0 milestone Oct 17, 2019
@shorowit shorowit requested a review from nmerket October 17, 2019 18:06
@nmerket nmerket added the merge label Oct 22, 2019
nmerket
nmerket approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor
@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nmerket nmerket merged commit 4a80efe into master Oct 23, 2019
@nmerket nmerket deleted the adjacent_to_other_housing_unit branch October 23, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerket nmerket nmerket approved these changes

Assignees
No one assigned
Labels
energy rating index enhancement merge schemas
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shorowit @nmerket
0