8000 Window sub-components by nmerket · Pull Request #202 · hpxmlwg/hpxml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Window sub-components #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 28, 2019
Merged

Window sub-components #202

merged 9 commits into from
Oct 28, 2019

Conversation

nmerket
Copy link
Contributor
@nmerket nmerket commented Oct 15, 2019

Fixes #12.

Moving a bunch of window features into separate sub components with their own ids.

BaseElements_WindowInfo

Questions:

  • MoveableInsulation/Material uses the same list that's in any other insulation element. Is that appropriate here?
  • Should Overhangs be connected to or under ExteriorShading?
  • Should interior shading be similarly described?
  • Did I miss anything?

@nmerket nmerket changed the title creating window sub components Window sub-components Oct 15, 2019
@nmerket nmerket requested review from shorowit and GamalielL October 15, 2019 21:57
@nmerket nmerket added this to the v3.0 milestone Oct 15, 2019
@GamalielL
Copy link
GamalielL commented Oct 22, 2019

Questions:

  • MoveableInsulation/Material uses the same list that's in any other insulation element. Is that appropriate here?

Most of the selections are not appropriate. I don't think the type of insulation is very important in this situation, It may not be readily observable given that the insulation panels may be purchased as a finished product

  • Should Overhangs be connected to or under ExteriorShading?

I don't think so. They are part of the home constructions, where as the exterior shading products are more like accessories. They also have a separate set of properties.

  • Should interior shading be similarly described?

I don't think so. I think it generally treated as a decorative choice rather than an energy choice. It's impact is also very subject to occupant behavior.

  • Did I miss anything?

Probably :-)

@nmerket
Copy link
Contributor Author
nmerket commented Oct 22, 2019
  • Remove MoveableInsulation/Material.
  • Make InteriorShading similar to ExteriorShading.
  • Give ExteriorShading summer and winter shading factors.
  • Keep movable insulation and interior shading separate, but document for devices that provide both.
  • Shading factors: document that 1 is no effect, and 0 is opaque. @lirainer to investigate and verify the definition.

@GamalielL
Copy link

@nmerket That third item should be adding summer and winter shading factors

@nmerket
Copy link
Contributor Author
nmerket commented Oct 22, 2019

@GamalielL Thanks fixed it.

@nmerket
Copy link
Contributor Author
nmerket commented Oct 22, 2019

Including the changes discussed today:

BaseElements_WindowInfo

@lirainer
Copy link

Some thoughts on the ShadingFactor elements:

  • Should definitely stay with the 1 is no effect and 0 is opaque convention. This is used by both building models (SC, SHGC, shading multipliers, etc) and by product vendors (window films, solar screens, etc) in their specifications (SHGC, g-value, etc).
  • I think the issue with interpretation occurs due to having Shade in the name of the element. People may interpret this to mean that the element affects the fraction of shading rather than solar gain.
  • We should definitely add documentation explaining the usage.
  • We should consider changing the name of the elements to use something more intuitive. Some options:
    • SolarGain
    • SolarFactor
    • SolarTransmittance
  • I looked in BEDES and BuildingSync and didn't find anything appropriate.

@GamalielL
Copy link
GamalielL commented Oct 23, 2019 via email

@shorowit
Copy link
Contributor
shorowit commented Oct 23, 2019

ACCA Manual J and RESNET calls it Internal Shading Coefficient (ISC).

@pfairey
Copy link
pfairey commented Oct 23, 2019 via email

@RDmitchell
Copy link

If ShadingFactor is supposed to be equivalent to SHGC, I don't think you want to have "Interior" as part of the name.

@nmerket
Copy link
Contributor Author
nmerket commented Oct 24, 2019

I'm going to call them SummerShadingCoefficient and WinterShadingCoefficient.

@nmerket
Copy link
Contributor Author
nmerket commented Oct 24, 2019

Here's what the shading factors coefficients look like now.

image

And the annotations read:

Winter Shading Coefficient

The shading coefficient to apply during the winter months. Shading coefficients are defined as a multiplier on transmittance: 1 is transparent, 0 is opaque.

Summer Shading Coefficient

The shading coefficient to apply during the summer months. Shading coefficients are defined as a multiplier on transmittance: 1 is transparent, 0 is opaque.

@lirainer
Copy link

@nmerket What about the ShadingFactor in WindowFilm:

<xs:element minOccurs="0" name="ShadingFactor" type="xs:decimal"/>

@nmerket
Copy link
Contributor Author
nmerket commented Oct 25, 2019

@lirainer Good catch. I made the change.

@nmerket nmerket merged commit e48f029 into master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create sub-components for storm windows, moveable insulation, shading devices
6 participants
0