DHW Controllers #200
Merged
DHW Controllers #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: includes the home automation branch from #198. Probably should be merged after that. |
nmerket
commented
Oct 15, 2019
| <xs:annotation> | ||
| <xs:documentation>[deg F]</xs:documentation> | ||
| </xs:annotation> | ||
| </xs:element> | ||
| <xs:element minOccurs="0" name="UsesDesuperheater" | ||
| type="xs:boolean"> | ||
| <xs:element minOccurs="0" name="HasMixingValve" type="xs:boolean"/> |
There was a problem hiding this comment.
Here's the new HasMixingValve element.
nmerket
commented
Oct 15, 2019
Comment on lines
+1396
to
+1409
| <xs:element maxOccurs="unbounded" minOccurs="0" name="WaterHeatingControl"> | ||
| <xs:complexType> | ||
| <xs:sequence> | ||
| <xs:group ref="SystemInfo"/> | ||
| <xs:element ref="ConnectedDevice"/> | ||
| <xs:element minOccurs="0" name="Model" type="xs:string"/> | ||
| <xs:element minOccurs="0" name="Manufacturer" type="xs:string"/> | ||
| <xs:element minOccurs="0" name="SerialNumber" type="xs:string"/> | ||
| <xs:element minOccurs="0" name="ControlTechnology" type="DHWControllerTechnology"/> | ||
| <xs:element minOccurs="0" name="TemperatureControl" type="DHWTemperatureControl"/> | ||
| <xs:element minOccurs="0" ref="extension"/> | ||
| </xs:sequence> | ||
| </xs:complexType> | ||
| </xs:element> |
There was a problem hiding this comment.
Here's the new WaterHeatingControl element.
nmerket
commented
Oct 15, 2019
Comment on lines
+2201
to
+2212
| <xs:simpleType name="DHWControllerTechnology"> | ||
| <xs:restriction base="xs:string"> | ||
| <xs:enumeration value="smart"/> | ||
| <xs:enumeration value="timer"/> | ||
| </xs:restriction> | ||
| </xs:simpleType> 8000 | ||
| <xs:simpleType name="DHWTemperatureControl"> | ||
| <xs:restriction base="xs:string"> | ||
| <xs:enumeration value="fixed"/> | ||
| <xs:enumeration value="variable"/> | ||
| </xs:restriction> | ||
| </xs:simpleType> |
There was a problem hiding this comment.
And the enumerations.
|
It looks like my editor decided to reformat all the schemas here. There's also the changes from #198. It's making the diffs big. I highlighted the important stuff above. |
GamalielL
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #172.
Add the following element under
Building/BuildingDetails/Systems/WaterHeating.It also adds a boolean element
HasMixingValvetoWaterHeatingSystem.