8000 Adds desuperheater flexibility by shorowit · Pull Request #184 · hpxmlwg/hpxml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds desuperheater flexibility #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2019
Merged

Adds desuperheater flexibility #184

merged 2 commits into from
Jul 26, 2019

Conversation

shorowit
Copy link
Contributor
@shorowit shorowit commented Jun 7, 2019 •
edited
Loading

WaterHeatingSystem elements already support describing a desuperheater, however:

  • It's assumed to be attached to a geothermal heat pump
  • The RelatedHeatingSystem is confusingly named since you would point to a HeatPump and not a HeatingSystem

This PR adds the flexibility of attaching a desuperheater to an air source heat pump or an air conditioner. While less common, these residential systems exist. The PR allows this by:

  • Renaming HasGeothermalDesuperheater to UsesDesuperheater. Description: "Indicates whether this water heater uses a desuperheater. The attached heat pump or air conditioner can be referenced in the RelatedHVACSystem element."
  • Renaming RelatedHeatingSystem to RelatedHVACSystem. Description: "Reference a HeatingSystem, HeatPump, or CoolingSystem."

These changes should still work for other uses of the RelatedHVACSystem, like a combination boiler.

cc @yzhou601

@shorowit
Renames HasGeothermalDesuperheater to HasDesuperheater (with updated …
0d2b7e9 
…annotation) and renames RelatedHeatingSystem to RelatedHVACSystem.
@shorowit shorowit changed the title Desuperheaters Adds desuperheater flexibility Jun 7, 2019
@shorowit shorowit requested a review from nmerket July 2, 2019 15:10
@shorowit
Copy link
Contributor Author
shorowit commented Jul 2, 2019
  • "UsesDesuperheater" instead of "HasDesuperheater"?

@shorowit shorowit added the merge label Jul 2, 2019
@yzhou601 yzhou601 mentioned this pull request Jul 2, 2019
Merged
3 tasks
@nmerket nmerket merged commit d066f04 into master Jul 26, 2019
@nmerket nmerket deleted the desuperheater branch July 26, 2019 16:41
@nmerket nmerket added this to the v3.0 milestone Oct 30, 2019
@bpark1327 bpark1327 mentioned this pull request Apr 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerket nmerket Awaiting requested review from nmerket

Assignees
No one assigned
Labels
breaking change energy rating index enhancement merge schemas
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shorowit @nmerket
0