Adds fuel type element for heat pumps #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmerket
approved these changes
May 7, 2019
| @@ -571,9 +571,9 @@ | |||
| <xs:element minOccurs="0" name="RoofColor" | |||
| type="WallAndRoofColor"/> | |||
| <xs:element minOccurs="0" name="SolarAbsorptance" | |||
| type="SolarAbsorptance"/> | |||
| type="SolarAbsorptance"/> | |||
There was a problem hiding this comment.
I've seen these whitespace changes in a couple PRs now. It might be some auto formatting that OxygenXML does. Hopefully this doesn't cause conflicts.
There was a problem hiding this comment.
Yes. Probably best to apply the Oxygen formatting to master and then merge it into all the PRs to make the whitespace diffs go away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, heat pumps powered by natural gas exist. This change also makes it easier for software developers to loop through all HVACPlant system types and grab the fuel type.