Standardize Locations #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…To to FrameFloor element.
|
I thought we were going to make one enum list for all locations instead of making all the enum lists have the same enumerations. |
|
I like that this proposal is more backwards compatible.
ᐧ
…On Fri, Jan 4, 2019 at 12:21 PM Noel Merket ***@***.***> wrote:
I thought we were going to make one enum list for all locations instead of
making all the enum lists have the same enumerations.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#156 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJQHDN-a7zYTZ01HPacEc0ia64rFXoZtks5u_42CgaJpZM4Zo6V9>
.
--
Gamaliel Lodge
OptiMiser LLC
www.optimiserenergy.com
|
|
@GamalielL To be clear, you prefer having the separate enum lists (as implemented in the PR) as opposed to one enum list? |
|
It is preferable from my position as a legacy developer, because it make
the v3 transition lest costly. If I was building a new HPXML application,
then a single list would be cleaner.
ᐧ
…On Fri, Jan 4, 2019 at 3:26 PM Scott Horowitz ***@***.***> wrote:
@GamalielL <https://github.com/GamalielL> To be clear, you prefer having
the separate enum lists (as implemented in the PR) as opposed to one enum
list?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#156 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJQHDBA43N8VSd4dE5fnqmd9uGzs4hcMks5u_7j-gaJpZM4Zo6V9>
.
--
Gamaliel Lodge
OptiMiser LLC
www.optimiserenergy.com
|
|
Should DuctLocation have a "roof deck" choice too? |
|
I think roof deck is a good addition. Duct location should also have "under slab" and "exterior walls". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #143.
AdjacentTo
DuctLocation
UnitLocation
LaundryMachineLocation
RefrigeratorLocation
SpotVentilationLocation
VentilationFanLocation