8000 Additional PV fields by shorowit · Pull Request #147 · hpxmlwg/hpxml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Additional PV fields #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2019
Merged

Additional PV fields #147

merged 2 commits into from
May 23, 2019

Conversation

shorowit
Copy link
Contributor
@shorowit shorowit commented Oct 11, 2018 •
edited
Loading

Adds new PV fields for module type, tracking, and system losses.

@shorowit shorowit requested a review from nmerket October 11, 2018 20:52
@shorowit
Copy link
Contributor Author
shorowit commented Nov 8, 2018

Just realized that the ArrayType enumerations "fixed open rack" and "fixed roof mount" have some overlap with the existing Location element. Not sure what the best path forward is.

@shorowit
Copy link
Contributor Author
shorowit commented May 1, 2019 •
edited
Loading

To address this, I'll update the ArrayType enumerations from "fixed open rack" and "fixed roof mount" to just "fixed". And rename it to Tracking. The existing Location element will specify whether it is roof or ground mounted.

@shorowit
Copy link
Contributor Author
shorowit commented May 7, 2019

Look at Orange Button.

@shorowit shorowit added the merge label May 7, 2019
@nmerket nmerket merged commit e5d85f9 into master May 23, 2019
@nmerket nmerket deleted the photovoltaics branch May 23, 2019 21:54
@nmerket nmerket added this to the v3.0 milestone Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerket nmerket Awaiting requested review from nmerket

Assignees
No one assigned
Labels
energy rating index enhancement merge schemas
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shorowit @nmerket
0