8000 ElectricPanel: add BranchCircuits and ServiceFeeders by joseph-robertson · Pull Request #435 · hpxmlwg/hpxml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ElectricPanel: add BranchCircuits and ServiceFeeders #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Apr 4, 2025
Merged

ElectricPanel: add BranchCircuits and ServiceFeeders #435

merged 36 commits into from
Apr 4, 2025

Conversation

joseph-robertson
Copy link
Contributor
@joseph-robertson joseph-robertson commented Jan 9, 2025 •
edited
Loading

Add 4 new fields to ElectricPanel: HeadroomSpaces, RatedTotalSpaces, BranchCircuits, and ServiceFeeders.

ElectricPanel:

  • HeadroomSpaces (integer greater than or equal to zero)
  • RatedTotalSpaces (integer greater than zero)

image

BranchCircuits mirrors a main panel (or subpanel) breaker box:

  • voltage (120, 240)
  • max current rating (A)
  • occupied spaces (0.0, 0.5, 1.0, 2.0)
  • attached component(s)
  • attached subpanel

image

ServiceFeeders supports service load calculations (e.g., 2023 NEC load-based):

  • load type (heating, cooling, hot water, clothes dryer, dishwasher, range/oven, refrigeration, mech vent, permanent spa heater, permanent spa pump, pool heater, pool pump, well pump, electric vehicle charging, lighting, kitchen, laundry, other)
  • power rating (W, double greater than or equal to zero)
  • new load (boolean)
  • number of appliances (integer greater than or equal to zero)
  • attached component(s)

image

@joseph-robertson joseph-robertson self-assigned this Jan 9, 2025
shorowit
shorowit reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor
@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked very closely, just happened to notice these.

@joseph-robertson joseph-robertson mentioned this pull request Jan 13, 2025
Draft
21 tasks
@joseph-robertson joseph-robertson marked this pull request as ready for review January 21, 2025 22:57
@joseph-robertson joseph-robertson changed the title ElectricPanel: add BranchCircuits and DemandLoads ElectricPanel: add BranchCircuits and ServiceFeeders Feb 4, 2025
@shorowit shorowit requested a review from nmerket February 13, 2025 21:49
nmerket
nmerket reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor
@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. One comment about units below. Also, does it make sense to have some connection between BranchCircuits and ServiceFeeders?

@lixiliu
Copy link
lixiliu commented Feb 19, 2025

Looks pretty good. One comment about units below. Also, does it make sense to have some connection between BranchCircuits and ServiceFeeders?

BranchCircuits and ServiceFeeders are loosely connected by the systems they share but they should not be connected directly as we don't always count all the loads on a single branch circuit (e.g., if a branch circuit has a dishwasher and a gas water heater, the service feeder would only want to take the dishwasher load).

@lixiliu
Copy link
lixiliu commented Feb 28, 2025

Is it possible to rename Headroom as HeadroomSpaces in the schema, this way it's clear that it's about space? We use the term headroom in both capacity and space calculations.

shorowit
shorowit reviewed Mar 4, 2025
View reviewed changes
schemas/HPXMLBaseElements.xsd Outdated
<xs:sequence>
<xs:group ref="SystemInfo"/>
<xs:element minOccurs="0" name="LoadType" type="ServiceFeederLoadType"/>
<xs:element minOccurs="0" name="PowerRating" type="HPXMLDouble">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be required to be greater than zero?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bffc593

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be greater than or equal to zero.

@joseph-robertson
Copy link
Contributor Author

Is it possible to rename Headroom as HeadroomSpaces in the schema, this way it's clear that it's about space? We use the term headroom in both capacity and space calculations.

bffc593

@nmerket nmerket added the merge label Mar 13, 2025
@nmerket nmerket linked an issue Mar 13, 2025 that may be closed by this pull request
Subpanels, circuits, breakers/slots, smart features, etc on ElectricPanel #422
Closed
@nmerket nmerket merged commit b5fbc02 into master Apr 4, 2025
2 checks passed
@nmerket nmerket deleted the electric_panel2 branch April 4, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerket nmerket nmerket left review comments

@shorowit shorowit shorowit left review comments

@lixiliu lixiliu lixiliu left review comments

Assignees

@joseph-robertson joseph-robertson

Labels
enhancement merge schemas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subpanels, circuits, breakers/slots, smart features, etc on ElectricPanel
4 participants
@joseph-robertson @lixiliu @nmerket @shorowit
0