8000 Fix `WaterHeaterImprovement/PipeInsulated` element by shorowit · Pull Request #401 · hpxmlwg/hpxml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix WaterHeaterImprovement/PipeInsulated element #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

shorowit
Copy link
Contributor
@shorowit shorowit commented Feb 7, 2024

Changes the element from a string to boolean datatype.

@shorowit shorowit requested a review from nmerket February 7, 2024 16:58
@shorowit shorowit added this to the v4.0-rc4 milestone Feb 20, 2024
@shorowit shorowit self-assigned this Mar 8, 2024
@shorowit
Copy link
Contributor Author

Seems okay, but we should reconsider all of these FooImprovement elements that are halfway between building description elements and halfway between measures.

@shorowit shorowit added the merge label Mar 14, 2024
@nmerket
Copy link
Contributor
nmerket commented Mar 20, 2024

@nmerket nmerket merged commit 7ea333f into master Apr 18, 2024
@nmerket nmerket deleted the pipe_insulated branch April 18, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0