8000 add completion for `ch-run` by lucaudill · Pull Request #1652 · hpc/charliecloud · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 27, 2025. It is now read-only.

add completion for ch-run #1652

Merged
merged 10 commits into from
May 22, 2023
Merged

add completion for ch-run #1652

merged 10 commits into from
May 22, 2023

Conversation

lucaudill
Copy link
Collaborator

partially addresses #1633.

@lucaudill lucaudill requested a review from reidpr May 17, 2023 17:25
@reidpr reidpr added this to the 0.33 milestone May 18, 2023
@lucaudill lucaudill marked this pull request as ready for review May 18, 2023 16:21
Copy link
Collaborator
@reidpr reidpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Several comments in-line though.

lucaudill and others added 2 commits May 18, 2023 10:39
Co-authored-by: Reid Priedhorsky <1682574+reidpr@users.noreply.github.com>
@lucaudill lucaudill requested a review from reidpr May 22, 2023 22:25
Copy link
Collaborator
@reidpr reidpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, merging!

@reidpr reidpr merged commit 75e0d24 into master May 22, 2023
@reidpr reidpr deleted the run-completion_1633 branch May 22, 2023 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0