This repository was archived by the owner on May 27, 2025. It is now read-only.
update examples, add libfabric #1449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 27, 2023
Closed
reidpr
suggested changes
Jan 27, 2023
There was a problem hiding this comment.
OK this looks very nice, a real advance for Charliecloud. Lots of suggestions in-line. General comments:
- My brain hurts following the logic. Do we need to have it reviewed by someone who knows this MPI stuff?
- Let's make an issue to add libfabric injection (or whatever a good description of the new MPI functionality is).
- Please write up a (short!) paragraph to share internally and with the team summarizing this improvement and why it's cool.
- The documentation is very well written.
bin/ch-fromhost
Outdated
Comment on lines
61
to
72
| -d, --dest DST place following files in IMGDIR/DST, overriding inference | ||
| -d, --dest DST place preceding files in IMGDIR/DST, overriding inference |
There was a problem hiding this comment.
Is this really resolved? Doesn't in fact affect things that follow it on the command line?
reidpr
suggested changes
Feb 8, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #1443, #1549, and possibly others.
Makes #256 moot.