print grouped common option help in subcommands #1394
Conversation
935d806 to
8c535bb
Compare
There was a problem hiding this comment.
I agree, it is too long and messy. Do we need to distinguish the common opts by group, e.g., build cache common opts? Feels like one lump of common opts is easier to read.
My next thought was to suppress common opts altogether from sub-command help but it appears that is what caused this issue?
That grouping came "for free" because those three options are mutually exclusive. I don't know how to list them in the same group as the others in the help.
Yes, that's what we used to do, but it triggers the argparse bug. |
Closes #1372.
This works around an
argparsebug by changing our approach to subcommand help. Specifically, this PR adds help for common options in the help for each subcommand, though segregated into groups. The bug was triggered by suppressing help for the common options.I don't love it. The usage string is too long and messy. However, I don't have good ideas about a different workaround.