[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Fix potential github action smells #5668

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ci] Fix potential github action smells #5668

wants to merge 1 commit into from
+9 −0

Conversation

ceddy4395
Copy link

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

fixed: #5667

📝 What does this PR do?

Hey! 🙂
I want to contribute the following changes to your workflow:

  • Avoid executing scheduled workflows on forks
  • Use 'if' for upload-artifact action
  • Use permissions whenever using Github Token

These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ceddy4395 ceddy4395 requested a review from a team as a code owner April 28, 2024 07:40
@ceddy4395
Fix gha smells:
ef46505 
- Avoid executing  scheduled workflows on forks
- Use 'if' for upload-artifact action
- Use permissions whenever using Github Token
ver217
ver217 reviewed Jun 12, 2024
View reviewed changes
.github/workflows/compatiblity_test_on_schedule.yml
@@ -10,6 +10,7 @@ jobs:
matrix_preparation:
name: Prepare Container List
runs-on: ubuntu-latest
if: ${{github.event_name != 'schedule' || github.repository == 'hpcaitech-colossalai'}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the repo be hpcaitech/ColossalAI? And why not run when the event name is schedule?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ver217 ver217 ver217 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PROPOSAL]: Fix potential github action smells
2 participants
@ceddy4395 @ver217