feat(desktop): native tab keyboard shortcuts #5190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds native menu items with keyboard accelerators for tab management ops for the desktop app. These are standard desktop app shortcuts for tab control. The impl creates menu items with platform-appropriate accelerators (Cmd/Ctrl) that emit events to the frontend keybinding module so tab navigation and management can work. Closes HFE-907 Closes #3520 Closes HP-24 \### Shortcuts added - **Ctrl/Cmd+T**: Open new tab - **Ctrl/Cmd+W**: Close current tab - **Ctrl/Cmd+Alt+Left**: Navigate to previous tab - **Ctrl/Cmd+Alt+Right**: Navigate to next tab - **Ctrl/Cmd+0**: Navigate to the first tab - **Ctrl/Cmd+9**: Navigate to the last tab \### Implementation details The architecture uses Tauri's native menu system to register accelerators at the OS level, which then emit `hoppscotch_desktop_shortcut` events to the frontend. This approach makes shortcuts work globally within the app window and follow platform conventions. Global shortcuts would have prevented shortcuts from reaching other apps. The FE keybinding system was extended to support desktop-specific bindings through kernel mode detection, to separate base web shortcuts from desktop-only shortcuts like these. Some additions to tab service: methods like `goToNextTab()`, `goToPreviousTab()`, `goToLastTab()`, `reopenClosedTab()` plus some foundation for future shortcut expansion. \### Notes to reviewers This addresses the UX issue where users would accidentally close the entire app when trying to close tabs with Ctrl/Cmd+W. The shortcuts now match standard desktop application behavior across most browsers and also IDEs to an extent. All existing keyboard shortcuts remain functional. The desktop shortcuts only activate when running in desktop kernel mode, so no changes web app behavior.
b298c12 to
2ea9e93
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
2cfc140 to
b26ff05
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
"9" -> "(" -> first tab
"0" -> ")" -> last tab
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds native desktop tab management keyboard shortcuts to Hoppscotch Desktop, implementing standard accelerator behavior using Tauri’s native menu system and extending the frontend keybinding system to support desktop‐specific actions.
- Implements new menu items for actions like open new tab, close tab, reopen closed tab, and navigation through tabs.
- Extends the tab service and spotlight searcher along with updating keybindings, actions, and locales to support the new desktop shortcuts.
- Minor dependency update (adding @tauri-apps/api) and build tooling changes (cargo-tauri added in devenv.nix).
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/hoppscotch-desktop/src-tauri/src/main.rs | Fixed missing semicolons on early return statements. |
| packages/hoppscotch-desktop/src-tauri/src/lib.rs | Added Tauri menu definitions with appropriate accelerators for tab actions. |
| packages/hoppscotch-common/src/services/tab/tab.ts | Extended TabService with methods for tab navigation and closed tab history management. |
| packages/hoppscotch-common/src/services/tab/index.ts | Updated TypeScript interface to include new tab navigation methods. |
| packages/hoppscotch-common/src/services/spotlight/searchers/tab.searcher.ts | Added desktop-only actions with related icon imports for tab navigation. |
| packages/hoppscotch-common/src/pages/index.vue & graphql.vue | Registered new actions for tab navigation/reopening in the UI. |
| packages/hoppscotch-common/src/helpers/keybindings.ts | Integrated desktop-specific keybindings and Tauri event listener for shortcut handling. |
| packages/hoppscotch-common/src/helpers/actions.ts | Registered new action identifiers for tab navigation and reopen. |
| packages/hoppscotch-common/package.json & locales/en.json | Updated dependencies and locale strings for new shortcut actions. |
| devenv.nix | Added cargo-tauri for development environment tooling. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
AndrewBastin
approved these changes
Jun 24, 2025
jamesgeorge007
approved these changes
Jun 24, 2025
1 task
javi2754
pushed a commit
to javi2754/hoppscotch
that referenced
this pull request
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds native menu items with keyboard accelerators for tab management ops for the desktop app. These are standard desktop app shortcuts for tab control.
Closes HFE-907
Closes #3520
Closes HP-24
Shortcuts added
(, navigate to the left-most tab), navigate to the right-most tab9 comes before 0 on QWERTY so it seems more ergonomic.
Implementation details
The impl creates menu items with platform-appropriate accelerators (Cmd/Ctrl) that emit events to the frontend keybinding module so tab navigation and management can work.
The architecture uses Tauri's native menu system to register accelerators at the OS level, which then emit
hoppscotch_desktop_shortcutevents to the frontend.This approach makes shortcuts work globally within the app window and follow platform conventions. Global shortcuts would have prevented shortcuts from reaching other apps (global shortcuts are system level).
The FE keybinding system is extended to support desktop-specific bindings through kernel mode detection, to separate base web shortcuts from desktop-only shortcuts like these (mentioned above).
Some additions to tab service: methods like
goToNextTab(),goToPreviousTab(),goToLastTab()plus some foundation / plumbing for future shortcut expansion.Notes to reviewers
This also addresses the UX issue where users would accidentally close the entire app when trying to close tabs with Ctrl/Cmd+W.
The shortcuts now match standard desktop application behavior across most browsers (firefox, chrome, etc) and also IDEs to an extent (think VS code). The desktop shortcuts only activate when running in desktop kernel mode, so no changes web app behavior.