Some layout adjustments to allow prompts of any size #52
Conversation
|
Does seem to fix the prompt! But break the "Magic Undo" (which isn't hard to break!) It expected it could just walk backwards through the divs, reactivating the last one that was marked input. It was pretty much hacked together--but, I am attached to the feature. It's probably time for me to sit down and do some detailed looking over of what's there, myself. We're further down the road and know what kinds of questions to ask (in fact, maybe we should have a "testing checklist" script, which walks you through various features that should work and tells you to do them and observe if you saw the right effects?) Thanks for this... what I should probably do is give the code a going-over with the more modern understandings... and think about what the direction for the magic undo feature is e.g. prompt rewriting If you have ideas feel free to pitch in or experiment--but it seems we have some workarounds and strategies for solving the problem at this point. |
|
@hostilefork I have updated magic undo to no longer break with my layout adjustments. It appears to be working okay in my tests, but let me know if you see any further issues.
Yes, this would be nice to have. |
|
I tried it out today and it seems good to me! Thanks for attacking the issue with magic undo--it may not be designed right, but through this you're learning enough about what it's trying to do to do it right. :-) I pushed the WATCH dialect a little farther today, and am starting some documentation for it. It's kind of a fun thing: https://github.com/hostilefork/replpad-js/wiki/WATCH-Dialect-Notes I dropped the JavaScript table-dragging because it was too much of a sidetrack, and I found a sort-of-lame-but-good-enough way to do it with pure CSS: replpad-js/watchlist/watchlist.css Line 62 in ab84008 The real goal in having these things fleshed out is to keep creating examples of clients and their needs to inform the rewrite of the JS extension. And it pretty much needs a rewrite to get the cancellation and errors under control. :-/ |
Here is a proper solution for #50. It puts the prompt and input into their own divs and wraps a container around them. This allows the input div to expand to any remaining screen width without wrapping to the next line.
It has been tested on the latest Chrome and Firefox, using
do <nzpower>and at different / smaller screen sizes. This should resolve all the issues you guys were finding, but it would be good to do a few tests of your own before merging in case there was something I overlooked.