Add IsComputed helper for field #139
Conversation
|
Could you please add tests? Could you also add more of a description to the PR? I'm struggling to figure out what this is for or how it would be useful. |
fa6ae09 to
a36a9bb
Compare
|
Added a better commit message and a test. The only real use case is so that I can use |
A helper function on the `Field` type so that unpacking a struct into a worsheet can avoid manipulating fields that should just be computed
a36a9bb to
07c151a
Compare
computed_by_test.go
Outdated
|
|
||
| "github.com/helloeave/dat/sqlx-runner" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestField_IsComputedBy(t *testing.T) { |
There was a problem hiding this comment.
Can you make this part of the Zuite
computed_by_test.go
Outdated
| "github.com/helloeave/dat/sqlx-runner" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| "math" | ||
| "strings" |
There was a problem hiding this comment.
I feel like these are in the wrong spot now?
There was a problem hiding this comment.
😬 Sorry, I should have just run goimports...
|
@pratikprasad you can't skip by specifying |
nvm @alexandrinaw explained to me that this is in the other conversion direction. let ws do its thing basically, chuck the struct's value. |
No description provided.