Fix owntracks test using libsodium #3975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move test to class with custom config setups and with config validation.
|
@MartinHjelmare, thanks for your PR! By analyzing the history of the files in this pull request, we identified @molobrakos, @pavoni and @kellerza to be potential reviewers. |
|
I'd appreciate if someone else can test this locally too, since Travis doesn't run the test in question. I've tested it with python3.5. |
|
Makes sense, I did not have libsodium installed during my last device_tracker cleanup so the test did not execute. If it passes for you with libsodium, you can merge it! 🐬 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
validation.
Related issue (if applicable): fixes #
Fixes #3958
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass