Make default duration 1/10th of a second for ZHA light calls #38739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with an integration ( |
Adminiuga
approved these changes
Aug 10, 2020
frenck
pushed a commit
that referenced
this pull request
Aug 12, 2020
* default duration to 1/10th of a second * update test
weissm
pushed a commit
to weissm/core
that referenced
this pull request
Aug 28, 2020
…sistant#38739) * default duration to 1/10th of a second * update test
hahn-th
pushed a commit
to hahn-th/core
that referenced
this pull request
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR will default the used transition to 1/10th of a second to fix issues where bulbs crash when changing color or brightness levels without a non 0 transition.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: