8000 Add scikit-build to installed env by pvizeli · Pull Request #38726 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add scikit-build to installed env #38726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2020
Merged

Add scikit-build to installed env #38726

merged 1 commit into from
Aug 10, 2020

Conversation

pvizeli
Copy link
Member
@pvizeli pvizeli commented Aug 10, 2020

Proposed change

Fix: https://dev.azure.com/home-assistant/Wheels/_build?definitionId=78&_a=summary

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@pvizeli pvizeli added this to the 0.114.0 milestone Aug 10, 2020
@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Aug 10, 2020
@pvizeli pvizeli merged commit c610558 into dev Aug 10, 2020
frenck pushed a commit that referenced this pull request Aug 12, 2020
@pvizeli @frenck
Add scikit-build to installed env (#38726)
57e99af
@pvizeli pvizeli deleted the fix-wheels branch January 4, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.114.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pvizeli @frenck @homeassistant
0