8000 Add scan_tag webhook to mobile app by balloob · Pull Request #38721 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add scan_tag webhook to mobile app #38721 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Add scan_tag webhook to mobile app #38721

merged 1 commit into from
Aug 10, 2020

Conversation

balloob
Copy link
Member
@balloob balloob commented Aug 10, 2020

Breaking change

Proposed change

Add a scan_tag webhook type to the mobile app. Sending it in for now will fire a new event tag_scanned with data {"tag_id": "abcd", "device_id": "qwer"}. Device ID is the device that scanned the tag.

This is going to be part of a new tag integration that is coming soon. For now adding this webhook to unblock the mobile apps from adding this.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with an integration (mobile_app) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob added this to the 0.114.0 milestone Aug 10, 2020
@balloob
Copy link
Member Author
balloob commented Aug 10, 2020

Putting this in the milestone to unblock the mobile apps.

@balloob balloob merged commit 52729e9 into dev Aug 10, 2020
@balloob balloob deleted the mobile-app-scan-tag branch August 10, 2020 15:54
zacwest added a commit to home-assistant/iOS that referenced this pull request Aug 10, 2020
- Updates to use the `scan_tag` webhook added in home-assistant/core#38721.
- Bumps Realm dependency and build numbers for the next build, since this is the only change for it.
frenck pushed a commit that referenced this pull request Aug 12, 2020
weissm pushed a commit to weissm/core that referenced this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0