8000 Ensure shared zeroconf is passed to homekit controller devices by bdraco · Pull Request #38678 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ensure shared zeroconf is passed to homekit controller devices #38678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2020
Merged

Ensure shared zeroconf is passed to homekit controller devices #38678

merged 1 commit into from
Aug 8, 2020

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Aug 8, 2020 •
edited
Loading

Proposed change

Ensure shared zeroconf is passed to homekit controller devices

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco bdraco added this to the 0.114.0 milestone Aug 8, 2020
@probot-home-assistant
Copy link

Hey there @Jc2k, mind taking a look at this pull request as its been labeled with an integration (homekit_controller) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco mentioned this pull request Aug 8, 2020
Closed
Jc2k
Jc2k approved these changes Aug 8, 2020
View reviewed changes
Copy link
Member
@Jc2k Jc2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdraco bdraco merged commit e304792 into home-assistant:dev Aug 8, 2020
balloob pushed a commit that referenced this pull request Aug 9, 2020
@bdraco @balloob
Ensure shared zeroconf is passed to homekit controller devices (#38678)
f1e3023
@bdraco bdraco mentioned this pull request Aug 9, 2020
Closed
@chemelli74 chemelli74 mentioned this pull request Aug 9, 2020
Closed
@Jc2k Jc2k mentioned this pull request Aug 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jc2k Jc2k Jc2k approved these changes

Assignees

@Jc2k Jc2k

Labels
cherry-picked cla-signed integration: homekit_controller small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.114.0
Development

Successfully merging this pull request may close these issues.

Homekit controller can still get stuck in _find_data_for_device_id / not using shared zeroconf
4 participants
@bdraco @Jc2k @balloob @homeassistant
0