Log which task is blocking startup when debug logging is on #38134 8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
approved these changes
Jul 23, 2020
|
I think it would be good to also log all pending tasks and when they are done. |
frenck
pushed a commit
that referenced
this pull request
Jul 24, 2020
* Log which task is blocking startup when debug logging for homeassistant.core is on * test needs to go one level deeper now
Merged
bdraco
added a commit
to bdraco/home-assistant
that referenced
this pull request
Jul 28, 2020
This is a followup to home-assistant#38134 which only added logging when a single task blocks for more than 60 seconds This change handles the case were we have a chain of tasks that block
20 tasks
hahn-th
pushed a commit
to hahn-th/core
that referenced
this pull request
May 2, 2025
* Add troubleshooting to Vodafone Station * apply rabbit comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Log the task stack when an integration is blocking startup.
Requires debug logging to be turned on for
homeassistant.coreIt is not pretty so I left it as debug only (hard to unpack these since they can be futures as well) but at least we can figure out what is going on. My custom
block_startupintegration that I made to test this is the cause in the below example:2020-07-23 23:31:31 DEBUG (MainThread) [homeassistant.core] Waited 60 seconds for task: <Task pending name='Task-585' coro=<async_setup.<locals>.wait_a_bit() running at /config/custom_components/block_startup/__init__.py:56> wait_for=<Future pending cb=[<TaskWakeupMethWrapper object at 0x7fd56a717520>()]> cb=[_wait.<locals>._on_completion() at /usr/local/lib/python3.8/asyncio/tasks.py:507]>Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: