Wrap found target in list #3809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robbiet480, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lwis, @balloob and @rmkraus to be potential reviewers. |
balloob
pushed a commit
that referenced
this pull request
Oct 11, 2016
* Wrap found target in list * Fix test_messages_to_targets_route
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where when sending a notification to a service with target attached (i.e.
notify.html5_unnamed_device_2) the target was not submitted to the platform as a list causing iteration over every character in the string.Thanks to @sgauche for finding this.