Stop GTFS component from overwriting friendly_name #3798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloobbot
reviewed
Oct 10, 2016
| @@ -233,7 +234,8 @@ def update(self): | |||
| trip = self._departure['trip'] | |||
|
|
|||
| name = '{} {} to {} next departure' | |||
| self._name = name.format(agency.agency_name, | |||
| self._name = self._custom_name or \ | |||
| name.format(agency.agency_name, | |||
There was a problem hiding this comment.
- 26: E127 continuation line over-indented for visual indent
|
🐬 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The
GTFSDepartureSensor.update()method always updatesself._name, overwriting any custom name that may have been passed to the platform inconfiguration.yaml. This is a quick change to correct that behaviour.Related issue (if applicable): N/A
Pull request in home-assistant.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable): N/AChecklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests passThere's currently no tests for the GTFS component. I'd be happy to assist writing some, but I'm not yet sure how to go about mocking a whole GTFS schema.