Changing import as powerview api did change. #3780
Conversation
|
@sander76, thanks for your PR! By analyzing the history of the files in this pull request, we identified @robbiet480, @balloob and @fabaff to be potential reviewers. |
|
Travis fails. I need to update my requirements_all.txt file. (running gen_requirements_all.py). But I have done that. Can anyone give me some ideas what to do now ? |
| 'https://github.com/sander76/powerviewApi/' | ||
| 'archive/cc6f75dd39160d4aaf46cb2ed9220136b924bcb4.zip#powerviewApi==0.2'] | ||
| 'https://github.com/sander76/powerviewApi/archive' | ||
| '/246e782d60d5c0addcc98d7899a0186f9d5640b0.zip' |
There was a problem hiding this comment.
You are missing something like #powerviewApi=0.2 at the end of the requirements line.
| @@ -64,6 +64,9 @@ cherrypy==8.1.0 | |||
| coinmarketcap==2.0.1 | |||
|
|
|||
| # homeassistant.scripts.check_config | |||
| colorama<=1 | |||
There was a problem hiding this comment.
This should not be getting updated. Please make sure you are on the latest dev version before running gen_requirements_all.py.
There was a problem hiding this comment.
@robbiet480
I am.... As a check I did a clone of the original repo (balloob's) and did a python script/gen_requirements_all.py (being on dev.). It also adds the colorama entry. So there is something going wrong...
|
@robbiet480 Did a manual remove of the colorama entry. Checks are passing now. Is this ok now you think ? |
Description:
Changing imports as powerview api has changed.
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass