Separate climate platform and presentation units #3755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloobbot
reviewed
Oct 8, 2016
| return self.hass.config.units.temperature_unit | ||
|
|
||
| @property | ||
| def _platform_unit_of_measurement(self): |
There was a problem hiding this comment.
- D400: First line should end with a period (not 'm')
|
Hrm. |
Maybe
|
@turbokongen did the backend for this and I worked on the polymer side of it. |
|
Related issue: #3605 |
balloob
requested changes
Oct 9, 2016
| return self.hass.config.units.temperature_unit | ||
|
|
||
| @property | ||
| def _platform_unit_of_measurement(self): |
There was a problem hiding this comment.
Can you rename this to temperature_unit?
balloob
approved these changes
Oct 11, 2016
|
🐬 🍺 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The
unit_of_measurementmethod in the climate component has an overloaded meaning. Firstly, the rest of home-assistant uses it as the unit that should be displayed to the user. Secondly, platforms in the climate component use it to represent the unit used by the backing system, and have to implement it, as it raises a NotImplementedError otherwise.This overload of meanings means that values are converted to the user's desired display unit, but the string which is appended for display is the unit used by the platform (often times not configurable).
This splits the two meanings into two separate attributes.
Related issue (if applicable): fixes #3445
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass