8000 Fix yr HTTP error handling by pnbruckner · Pull Request #36889 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix yr HTTP error handling #36889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

Fix yr HTTP error handling #36889

merged 1 commit into from
Jun 17, 2020

Conversation

pnbruckner
Copy link
Contributor

Proposed change

PR #36880 fixed the met.no integration, but the yr integration requires the same fix since it uses the same data source.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
sensor:
- platform: yr

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added bugfix integration: yr small-pr PRs with less than 30 lines. labels Jun 17, 2020
@pnbruckner pnbruckner requested a review from balloob June 17, 2020 20:29
MartinHjelmare
MartinHjelmare approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare mentioned this pull request Jun 17, 2020
Merged
@balloob balloob added this to the 0.111.4 milestone Jun 17, 2020
@balloob balloob merged commit 2883aac into dev Jun 17, 2020
@balloob balloob deleted the pnbruckner-yr branch June 17, 2020 20:40
balloob pushed a commit that referenced this pull request Jun 17, 2020
@pnbruckner @balloob
Fix yr HTTP error handling (#36889)
098d82f
8000
@probot-home-assistant
Copy link

Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with a integration (yr) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

hahn-th pushed a commit to hahn-th/core that referenced this pull request May 2, 2025
@Mayhem-SWE
Update scene.markdown (home-assistant#36889)
334991c 
Removed configuration variable "description" as such a variable does not exist (HA will give an error if you try to insert it).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@balloob balloob Awaiting requested review from balloob

Assignees

@Danielhiversen Danielhiversen

Labels
bugfix cla-signed integration: yr small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.111.4
Development

Successfully merging this pull request may close these issues.
5 participants
@pnbruckner @MartinHjelmare @Danielhiversen @balloob @homeassistant
0