8000 Bump Axis dependency to fix issue where ports dont initialize by Kane610 · Pull Request #36860 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump Axis dependency to fix issue where ports dont initialize #36860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

Bump Axis dependency to fix issue where ports dont initialize #36860

merged 1 commit into from
Jun 17, 2020

Conversation

Kane610
Copy link
Member
@Kane610 Kane610 commented Jun 16, 2020 •
edited
Loading

Breaking change

Proposed change

I apparently forgot making the initialise ports method end with ()

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Reported on the forums: https://community.home-assistant.io/t/axis-a8004-doorbell/204604

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@Kane610 Kane610 added this to the 0.111.4 milestone Jun 16, 2020
@Kane610 Kane610 mentioned this pull request Jun 16, 2020
Closed
@balloob balloob merged commit 94c8d74 into home-assistant:dev Jun 17, 2020
balloob pushed a commit that referenced this pull request Jun 17, 2020
@Kane610 @balloob
Bump Axis dependency to fix issue where ports dont initialize (#36860)
ec69edc
@balloob balloob mentioned this pull request Jun 17, 2020
Merged
@Kane610 Kane610 deleted the axis-fix_ports_not_initializing branch June 17, 2020 20:07
hahn-th pushed a commit to hahn-th/core that referenced this pull request May 2, 2025
@MaestroOnICe
Add iometer integration documentation (home-assistant#36860)
c69458f 
Co-authored-by: MaestroOnICe <justuskrebs@campus.tu-berlin.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed dependency-bump integration: axis small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.111.4
Development

Successfully merging this pull request may close these issues.

Axis Doorstation (A8105-E) doesn't report callbutton
3 participants
@Kane610 @balloob @homeassistant
0