8000 Remove powerwall attributes no longer present in latest firmware by bdraco · Pull Request #36667 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove powerwall attributes no longer present in latest firmware #36667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Jun 11, 2020

Currently the integration fails to setup on 1.47 US systems

Tesla removed these attributes on some 1.47 systems which broke everything for the US region after update. These were nice to haves that are not strictly needed so we can remove them.

Proposed change

Remove powerwall attributes no longer present in latest firmware

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @jrester, mind taking a look at this pull request as its been labeled with a integration (powerwall) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@meremortals70
Copy link
meremortals70 commented Jun 12, 2020

What has happened to my solar now sensor. I checked the Rest API and My Powerwall still reports it but it is gone from HA

HA now tells me my Powerwall software is old and to upgrade. The integration says I am running 1.4.6, however, when I log into the Powerwall or look at the app it says 1.4.7

@jrester
Copy link
Contributor
jrester commented Jun 13, 2020

@meremortals70 What Homeassistant Version are you running? And could you post the according Logs?

@meremortals70
Copy link

As part of ongoing configuration I updated Ubuntu today and a restart of the bare metal.

My solar now entity is reporting again and the HA integration now shows 1.4.7 as the Tesla version.

Strange as it has been a day since I did the HA upgrade and the solar entity was reporting after the upgrade and it just stopped overnight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0