8000 Process events from ZHA Window Covering Remote by Adminiuga · Pull Request #36489 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

10000 Process events from ZHA Window Covering Remote #36489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2020
Merged

Process events from ZHA Window Covering Remote #36489

merged 1 commit into from
Jun 5, 2020

Conversation

Adminiuga
Copy link
Contributor

Breaking change

Nope

Proposed change

Type of change

Mark WindowCovering channel as an eventable channel so we could receive event from the remote.

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

n/a

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@Adminiuga Adminiuga mentioned this pull request Jun 5, 2020
Closed
@Adminiuga Adminiuga added this to the 0.111.0 milestone Jun 5, 2020
@Adminiuga Adminiuga requested a review from dmulcahey June 5, 2020 20:45
@balloob balloob merged commit 1c329ff into home-assistant:dev Jun 5, 2020
@Adminiuga Adminiuga deleted the ac/zha-cover-event branch June 5, 2020 21:12
balloob pushed a commit that referenced this pull request Jun 5, 2020
@Adminiuga @balloob
Process events from ZHA Window Covering Remote (#36489)
85ee0a1
@Botap
Copy link
Botap commented Jun 8, 2020

Hi,
May be the issue is related that the IKEA Open/Close controller doesn't have a proper quirk file? When I join the Open/Close controller to the ZigBee network I see the following in the log file.
I am not an expert in ZHA at all, but it looks like it is considering a lot of quirk files but can't find the correct one. Now unfortunately I have no idea how to make a correct file but may be somebody else does with the information below?

020-06-08 21:57:21 DEBUG (MainThread) [zigpy.zdo] [0x0000:zdo] ZDO request ZDOCmd.Mgmt_Permit_Joining_req: [60, <Bool.false: 0>]
2020-06-08 21:57:28 DEBUG (MainThread) [zigpy.zcl] [0x5a12:1:0x0006] ZCL deserialize: <ZCLHeader frame_control= manufacturer=None tsn=127 command_id=66>
2020-06-08 21:57:28 DEBUG (MainThread) [zigpy.zcl] [0x5a12:1:0x0006] ZCL request 0x0042: [0, 1800, 0]
2020-06-08 21:57:28 DEBUG (MainThread) [zigpy.zcl] [0x5a12:1:0x0006] No handler for cluster command 66
2020-06-08 21:58:00 INFO (MainThread) [bellows.zigbee.application] ZDO Device announce: 0x4c3a, 08:6b:d7:ff:fe:21:b8:5a
2020-06-08 21:58:00 INFO (MainThread) [zigpy.application] Device 0x4c3a (08:6b:d7:ff:fe:21:b8:5a) joined the network
2020-06-08 21:58:00 DEBUG (MainThread) [zigpy.zdo] [0x4c3a:zdo] ZDO request ZDOCmd.Device_annce: [0x4c3a, 08:6b:d7:ff:fe:21:b8:5a, 128]
2020-06-08 21:58:00 INFO (MainThread) [zigpy.device] [0x4c3a] Requesting 'Node Descriptor'
2020-06-08 21:58:00 DEBUG (MainThread) [zigpy.util] Tries remaining: 2
2020-06-08 21:58:00 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x13 request
2020-06-08 21:58:01 INFO (MainThread) [zigpy.device] [0x4c3a] Node Descriptor:
2020-06-08 21:58:01 INFO (MainThread) [zigpy.device] [0x4c3a] Discovering endpoints
2020-06-08 21:58:01 DEBUG (MainThread) [zigpy.util] Tries remaining: 3
2020-06-08 21:58:01 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x15 request
2020-06-08 21:58:03 INFO (MainThread) [zigpy.device] [0x4c3a] Discovered endpoints: [1]
2020-06-08 21:58:03 INFO (MainThread) [zigpy.endpoint] [0x4c3a:1] Discovering endpoint information
2020-06-08 21:58:03 DEBUG (MainThread) [zigpy.util] Tries remaining: 3
2020-06-08 21:58:03 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x17 request
2020-06-08 21:58:04 INFO (MainThread) [zigpy.endpoint] [0x4c3a:1] Discovered endpoint information: <Optional endpoint=1 profile=260 device_type=515 device_version=1 input_clusters=[0, 1, 3, 9, 32, 4096, 64636] output_clusters=[3, 4, 6, 8, 25, 258, 4096]>
2020-06-08 21:58:04 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x19 request
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.zcl] [0x4c3a:1:0x0000] ZCL deserialize: <ZCLHeader frame_control= manufacturer=None tsn=25 command_id=Command.Read_Attributes_rsp>
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.endpoint] [0x4c3a:1] Manufacturer: �KE
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.endpoint] [0x4c3a:1] Model: TRADFRI open/close remote
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Checking quirks for �KE TRADFRI open/close remote (08:6b:d7:ff:fe:21:b8:5a)
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Considering <class 'bellows.zigbee.application.EZSPCoordinator'>
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Fail because device_type mismatch on at least one endpoint
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Considering <class 'zhaquirks.gledopto.soposhgu10.SoposhGU10'>
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Fail because endpoint list mismatch: {11, 13} {1}
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Considering <class 'zhaquirks.lutron.lzl4bwhl01remote.LutronLZL4BWHL01Remote2'>
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Fail because profile_id mismatch on at least one endpoint
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Considering <class 'zhaquirks.netvox.z308e3ed.Z308E3ED'>
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Considering <class 'zhaquirks.osram.a19twhite.A19TunableWhite'>
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Fail because endpoint list mismatch: {3} {1}
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Considering <class 'zhaquirks.philips.rom001.PhilipsROM001'>
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Considering <class 'zhaquirks.philips.rwl020.PhilipsRWL020'>
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Fail because endpoint list mismatch: {1, 2} {1}
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Considering <class 'zhaquirks.philips.rwl021.PhilipsRWL021'>
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Considering <class 'zhaquirks.smartthings.multi.SmartthingsMultiPurposeSensor'>
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Considering <class 'zhaquirks.smartthings.tag_v4.SmartThingsTagV4'>
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Considering <class 'zhaquirks.xbee.xbee3_io.XBee3Sensor'>
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Fail because endpoint list mismatch: {232, 230} {1}
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Considering <class 'zhaquirks.xbee.xbee_io.XBeeSensor'>
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.quirks.registry] Considering <class 'zhaquirks.xiaomi.mija.smoke.MijiaHoneywellSmokeDetectorSensor'>
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x1b request
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x1d request
2020-06-08 21:58:05 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x1f request
2020-06-08 21:58:06 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x21 request
2020-06-08 21:58:06 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x23 request
2020-06-08 21:58:06 DEBUG (MainThread) [zigpy.zcl] [0x4c3a:1:0x0020] ZCL deserialize: <ZCLHeader frame_control= manufacturer=None tsn=31 command_id=Command.Write_Attributes_rsp>
2020-06-08 21:58:06 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x25 request
2020-06-08 21:58:07 DEBUG (MainThread) [zigpy.zcl] [0x4c3a:1:0x0000] ZCL deserialize: <ZCLHeader frame_control= manufacturer=None tsn=33 command_id=Command.Read_Attributes_rsp>
2020-06-08 21:58:07 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x27 request
2020-06-08 21:58:08 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x29 request
2020-06-08 21:58:08 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x2b request
2020-06-08 21:58:08 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x2d request
2020-06-08 21:58:09 DEBUG (MainThread) [zigpy.zcl] [0x4c3a:1:0x0001] ZCL deserialize: <ZCLHeader frame_control= manufacturer=None tsn=41 command_id=Command.Configure_Reporting_rsp>
2020-06-08 21:58:09 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x2f request
2020-06-08 21:58:09 DEBUG (MainThread) [zigpy.device] [0x4c3a] Extending timeout for 0x31 request
2020-06-08 21:58:09 DEBUG (MainThread) [zigpy.zdo] [0x4c3a:zdo] ZDO request ZDOCmd.Mgmt_Permit_Joining_req: [180, <Bool.true: 1>]

@balloob
Copy link
Member
balloob commented Jun 8, 2020

Please create a new issue instead of responding to merged PRs.

@thd6n75 thd6n75 mentioned this pull request Sep 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

@dmulcahey dmulcahey Awaiting requested review from dmulcahey dmulcahey is a code owner

Assignees

@dmulcahey dmulcahey

@Adminiuga Adminiuga

Labels
bugfix cherry-picked cla-signed has-tests integration: zha small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.111.0
Development

Successfully merging this pull request may close these issues.

No zha_event for KE TRADFRI open/close remote
5 participants
@Adminiuga @Botap @balloob @dmulcahey @homeassistant
0