8000 Upgrade pysonos to 0.0.31 by bdraco · Pull Request #36483 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade pysonos to 0.0.31 #36483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2020
Merged

Upgrade pysonos to 0.0.31 #36483

merged 1 commit into from
Jun 5, 2020

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Jun 5, 2020 •
edited
Loading

Proposed change

Sonos now trys additional ports if 1400 is unavailable.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco bdraco added this to the 0.111.0 milestone Jun 5, 2020
amelchio
amelchio approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor
@amelchio amelchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🎉

There is some text mentioning port 1400 in the documentation but I don't know if it is worth updating it for this rare case.

@bdraco bdraco mentioned this pull request Jun 5, 2020
Merged
8 tasks
@bdraco
Copy link
Member Author
bdraco commented Jun 5, 2020

Great! 🎉

There is some text mentioning port 1400 in the documentation but I don't know if it is worth updating it for this rare case.

Might as well update the docs. Not that I read them before I opened the issue 🙈

@balloob balloob merged commit c0307dc into home-assistant:dev Jun 5, 2020
balloob pushed a commit that referenced this pull request Jun 5, 2020
@bdraco @balloob
Upgrade pysonos to 0.0.31 (#36483)
d1c083e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amelchio amelchio amelchio approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed dependency-bump integration: sonos small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.111.0
Development

Successfully merging this pull request may close these issues.

Sonos switches to polling when port 1400 is unavailable with no warning or fallback to next port
4 participants
@bdraco @amelchio @balloob @homeassistant
0