8000 Service.call_from_config will no longer mutate passed in config if nested templates by balloob · Pull Request #3628 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Service.call_from_config will no longer m 8000 utate passed in config if nested templates #3628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2016
Merged

Service.call_from_config will no longer mutate passed in config if nested templates #3628

merged 1 commit into from
Oct 1, 2016

Conversation

balloob
Copy link
Member
@balloob balloob commented Oct 1, 2016 •
edited
Loading

Description:
Service.call_from_config would mutate the passed in config when the config contained nested templates. It would replace the templates with the rendered value.

This has been fixed.

Example entry for configuration.yaml (if applicable):

automation:
  trigger:
    platform: event
    event_type: 'state_changed'
  action:
    service: notify.notify
    data_template:
      data:
        this_value: 'gets overwritten by rendered output: {{ False }}'

CC @pvizeli

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob balloob merged commit 412b535 into dev Oct 1, 2016
@balloob balloob deleted the service-mutate-data branch October 1, 2016 06:26
balloob added a commit that referenced this pull request Oct 1, 2016
@balloob
Service config calls will no longer mutate original config (#3628)
ef0e018
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balloob @pvizeli
0