Skip RFXtrx tests unless RFXTRX=RUN #3625
Conversation
|
Why was this line removed? I think that is the reason for why rfxtrx no longer is shutting down correctly. |
|
I did that when i was trying to make them faster. Not sure if I should have… My reasoning was that |
|
@Danielhiversen I am running a test now adding the closed connection and seeing what the impact is. |
|
@Danielhiversen my bad, you were right. I am running it a few more times to gather some more timings. |
|
Hmm, why is not _rfxtrx_shutdown() called when when self.hass.stop() is called from the tests? Is not the test_hass executing EVENT_HOMEASSISTANT_STOP when shutting down? |
|
It is sending the STOP event, so that's why I thought it could be removed. |
|
Even with the connection being closed properly, the tests have a significant impact on our test run. With RFXtrx tests enabled
Linting fails in these builds because I didn't remove the import of pytest (used to skip the tests) With RFXtrx tests disabled
|
d3a83fa to
905d4ca
Compare
The RFXtrx tests are not successfully cleaning up threads and are slowing down our CI runs. They went from 6 minutes to 35 minutes! Because our CI tests take more time and thus use more resources, Travis is giving us less runs.
For now we'll disable the RFXtrx tests. They can still be run by passing RFXTRX=RUN to py.test:
48167ce - This one was still fast
428f8c7 - This one was slow
CC @Danielhiversen