Nest operation modes #3609
Merged
Nest operation modes #3609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Sep 30, 2016
| @@ -62,13 +63,22 @@ def unit_of_measurement(self): | |||
| return TEMP_CELSIUS | |||
|
|
|||
| @property | |||
| def state(self): | |||
There was a problem hiding this comment.
Do not overwrite state. That's for the Climate ABC to decide (it currently returns self.operation_mode)
…on mode" This reverts commit 573ba02. Conflicts: homeassistant/components/climate/nest.py
|
Awesome! Coming to a hotfix near you soon 👍 🐬 |
|
@jawilson good catch on this. It makes sense the way you displayed it now. I tested your patch and looks good to me. It is nice that it shows Auto when running in range. Very clear 👍 Thanks for the good work! |
balloob
pushed a commit
that referenced
this pull request
Sep 30, 2016
* Add ability to change Nest mode to all available options * Make Nest state reflect current operation not current operation mode * Update Nest sensor to use operation mode * Fix linting * Revert "Make Nest state reflect current operation not current operation mode" This reverts commit 573ba02. Conflicts: homeassistant/components/climate/nest.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The Nest operation modes in #3606 don't match with what you can actually set. I made changes to the operation mode corresponds to what mode the thermostat is in (heat, cool, auto, off) and the climate state refers to the current operation it is taking (heat, cool, idle). I also update the Nest sensor to use
operation_modeinstead of the legacymodevalue.I honestly think the card should be updated so instead of
current_operationattribute it displays the climatestate.Checklist:
If code communicates with devices, web services, or a:
toxrun successfully. Your PR cannot be merged unless tests pass