8000 Check that no configuration is provided by fabaff · Pull Request #3553 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Check that no configuration is provided #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2016
Merged

Check that no configuration is provided #3553

merged 1 commit into from
Sep 30, 2016

Conversation

fabaff
Copy link
Member
@fabaff fabaff commented Sep 27, 2016

Description:
For various components is possible to add additional keys to the configuration. Like:

conversation:
  name: invalid_entry

This PR will check that only the component's name is present in the configuration.yaml file. To create the same error message as the components with a configuration the check is done for a schema and not None. Unfortunately the error messages contains two times the domain (could be tweaked with #3530), seems only to point to the right key for platforms (Check: zone->name1).

Invalid config for [conversation]: [name] is an invalid option for [conversation]. Check: conversation->conversation->name.
Invalid config for [mqtt]: [broker1] is an invalid option for [mqtt]. Check: mqtt->mqtt->broker1.

Related issue (if applicable): fixes 127528299

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@fabaff fabaff mentioned this pull request Sep 27, 2016
@balloob
Copy link
Member
balloob commented Sep 28, 2016

🐬

@balloob balloob added this to the 0.30 milestone Sep 28, 2016
@balloob balloob merged commit a7266ae into home-assistant:dev Sep 30, 2016
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
@fabaff fabaff deleted the voluptuous-components1 branch April 12, 2017 07:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0