8000 Add Netatmo data handler by cgtobi · Pull Request #35571 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Netatmo data handler #35571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 139 commits into from
Aug 4, 2020
Merged

Add Netatmo data handler #35571

merged 139 commits into from
Aug 4, 2020

Conversation

cgtobi
Copy link
Contributor
@cgtobi cgtobi commented May 13, 2020 •
edited
Loading

Breaking change

Proposed change

The data handling is changed to reduce the number of calls against the Netatmo API and the overall responsiveness is improved by taking advantage of webhook events if successfully established. Further it introduces the light platform to control the outdoor cameras flood light. It introduces services to set persons home/away in the Netatmo realm. The services to register and unregister the webhook with Netatmo manually is also brought back.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by 8000 running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@cgtobi cgtobi added the waiting-for-upstream We're waiting for a change upstream label May 14, 2020
@cgtobi cgtobi force-pushed the netatmo_data_handler branch 2 times, most recently from 9844e34 to cbdfbbd Compare May 15, 2020 18:51
@cgtobi cgtobi force-pushed the netatmo_data_handler branch from cbdfbbd to 814f8d4 Compare May 25, 2020 14:40
@cgtobi cgtobi mentioned this pull request Jun 5, 2020
Merged
20 tasks
@cgtobi cgtobi force-pushed the netatmo_data_handler branch 2 times, most recently from 4e3df1b to 7e661a1 Compare June 10, 2020 07:59
@cgtobi cgtobi marked this pull request as ready for review June 18, 2020 07:29
@cgtobi cgtobi force-pushed the netatmo_data_handler branch from a0ac7cd to ad3cb08 Compare June 20, 2020 21:25
@cgtobi cgtobi removed the waiting-for-upstream We're waiting for a change upstream label Jun 21, 2020
@cgtobi cgtobi force-pushed the netatmo_data_handler branch from 8905601 to 38c859d Compare June 21, 2020 08:40
@cgtobi cgtobi force-pushed the netatmo_data_handler branch 2 times, most recently from cedbe44 to 72a2a0d Compare July 9, 2020 08:56
This was referenced Jul 10, 2020
Closed
Merged
@cgtobi cgtobi force-pushed the netatmo_data_handler branch 2 times, most recently from 5786afb to ac22617 Compare July 13, 2020 20:14
bdraco
bdraco reviewed Jul 14, 2020
View reviewed changes
bdraco
bdraco reviewed Jul 14, 2020
View reviewed changes
bdraco
bdraco reviewed Jul 14, 2020
View reviewed changes
bdraco
bdraco reviewed Jul 14, 2020
View reviewed changes
bdraco
bdraco reviewed Jul 14, 2020
View reviewed changes
bdraco
bdraco reviewed Jul 14, 2020
View reviewed changes
bdraco
bdraco reviewed Jul 14, 2020
View reviewed changes
bdraco
bdraco reviewed Jul 14, 2020
View reviewed changes
bdraco
bdraco reviewed Jul 14, 2020
View reviewed changes
bdraco
bdraco reviewed Jul 14, 2020
View reviewed changes
cgtobi and others added 23 commits August 3, 2020 13:35
@cgtobi
Use UUID to clearly identify public weather areas
3822855
@cgtobi
Use subscription mode
3ffc9f4
@cgtobi
Move clean up of temporary data classes
57f517d
@cgtobi
Delay data class removal
4c7931a
@cgtobi
Fix linter complaints
14b6998
@cgtobi
Adjust test
d5552b0
@cgtobi
Only setup lights if webhook are registered
6d1d360
@cgtobi
Prevent crash with old config entries
911b784
@cgtobi < 10000 /div>
Don't cache home ids
4faf64d
@cgtobi
Remove stale code
43f374f
@cgtobi
Fix coordinates if entered mixed up by the user
c5d925d
@cgtobi
Move nested function
b45c5c1
@cgtobi
Add test case for swapped coordinates
e5222ec
@cgtobi
Only wait for discovery entries
8312d93
@cgtobi
Only use what I need
41c5730
@cgtobi
Bring stuff closer to where it's used
769b609
@cgtobi
Auto clean up setup data classes
d816e19
@cgtobi
Code cleanup
c57148a
@cgtobi
Remove unneccessary lock
00fdb6e
@cgtobi @bdraco
Update homeassistant/components/netatmo/sensor.py
dab9bce 
Co-authored-by: J. Nick Koston <nick@koston.org>
@cgtobi @bdraco
Update tests/components/netatmo/test_config_flow.py
e52c68e 
Co-authored-by: J. Nick Koston <nick@koston.org>
@cgtobi
Clean up dead code
cb4b045
@cgtobi
Fix formating
8eecfbf
@cgtobi cgtobi force-pushed the netatmo_data_handler branch from 733174b to 8eecfbf Compare August 3, 2020 11:36
@cgtobi cgtobi merged commit 31dbdff into home-assistant:dev Aug 4, 2020
MartinHjelmare
MartinHjelmare reviewed Aug 4, 2020
View reviewed changes
@cgtobi cgtobi mentioned this pull request Aug 6, 2020
Merged
20 tasks
@cgtobi cgtobi deleted the netatmo_data_handler branch August 7, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed integration: netatmo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

netatmo not working
4 participants
@cgtobi @bdraco @MartinHjelmare @homeassistant
0