8000 Fix command line sensors removing quotes with template by shenxn · Pull Request #35559 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix command line sensors removing quotes with template #35559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 10, 2020
Merged

Fix command line sensors removing quotes with template #35559

merged 5 commits into from
Jun 10, 2020

Conversation

shenxn
Copy link
Contributor
@shenxn shenxn commented May 12, 2020

Proposed change

Fix the problem that command line sensors remove quotes in arguments when there is a template rendering.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@shenxn
Copy link
Contributor Author
shenxn commented May 17, 2020

@MartinHjelmare I made some changes to the test. Now it doesn't involve any I/O.

@MartinHjelmare MartinHjelmare self-assigned this Jun 10, 2020
MartinHjelmare
MartinHjelmare approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit c65e728 into home-assistant:dev Jun 10, 2020
@MartinHjelmare MartinHjelmare added this to the 0.111.1 milestone Jun 10, 2020
balloob pushed a commit that referenced this pull request Jun 11, 2020
@shenxn @MartinHjelmare @balloob
Fix command line sensors removing quotes with template (#35559)
4bccb6e 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@balloob balloob mentioned this pull request Jun 11, 2020
Merged
@jon-riches
Copy link

Hi, thanks for fixing this.
Just a note for future, it was a breaking change, as before this PR escaping quotes with a backslash worked, and now doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elupus elupus elupus left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@MartinHjelmare MartinHjelmare

Labels
bugfix cherry-picked cla-signed has-tests integration: command_line small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.111.1
Development

Successfully merging this pull request may close these issues.

sensor.command_line does not accept quoted arguments when using command template
6 participants
@shenxn @jon-riches @elupus @MartinHjelmare @balloob @homeassistant
0