Update unit tests for remote.py #2782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| bootstrap.setup_component(hass, 'api') | ||
|
|
||
| hass.start() | ||
| time.sleep(0.05) | ||
| def block_start(hass_obj): |
There was a problem hiding this comment.
You are replicating exactly what hass_obj.start() does: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/core.py#L127-L128
Sleeping 0.05 seconds allows Python switch to the WSGI server thread and boot up the sockets.
There was a problem hiding this comment.
Interesting, maybe releasing the GIL with such a sleep() fix some of my busy threads issues:
WorkerPool:All 12 threads are busy and 73 jobs pending
It always seems to happen around start & adding an array of many devices add_devices (and their state updates)
|
Awesome 🐬 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
test_remoteseems to be one of the culprits for tox sometimes failingChecklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass