8000 Fix script load module issue by awarecan · Pull Request #21763 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix script load module issue #21763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2019
Merged

Fix script load module issue #21763

merged 2 commits into from
Mar 8, 2019

Conversation

awarecan
Copy link
Contributor
@awarecan awarecan commented Mar 7, 2019

Description:

Proper fix the colorlog install issue in check_config script

To test, have some config folder contains invalid config

> pip uninstall colorlog
> hass --script check_config -c ../ha-config
INFO:homeassistant.util.package:Attempting install of colorlog==4.0.2
Testing configuration at ...

> pip install colorlog==3.1.2
> hass --script check_config -c ../ha-config
INFO:homeassistant.util.package:Attempting install of colorlog==4.0.2
Testing configuration at

> hass --script check_config -c ../ha-config
Testing configuration at

Related issue (if applicable): reverts #21754

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):



Checklist:


    

  •  The code change is tested and works locally.
    • 

  •  Local tests pass with tox. Your PR cannot be merged unless tests pass
    • 

  •  There is no commented out code in this PR.
    • 



If user exposed functionality or configuration variables are added/changed:



If the code communicates with devices, web services, or third-party tools:


    

  •  New dependencies have been added to the REQUIREMENTS variable (example).
    • 

  •  New dependencies are only imported inside functions that use them (example).
    • 

  •  New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
    • 

  •  New files were added to .coveragerc.
    • 



If the code does not interact with devices:


    

  •  Tests have been added to verify that the new code works.
    • 


    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



          

        
      




  





       
            



      

  
        





      

  
          

  
  

  
      @awarecan
  awarecan


          requested a review
  from kellerza
    as a code owner


    March 7, 2019 19:47    
    




    

    

      
    

    


      

          @homeassistant
homeassistant




            added
      

  cla-signed


      

  core


      

  small-pr

  PRs with less than 30 lines.

  labels


      Mar 7, 2019

    

  



    

    

      
    

    


      

          @ghost
  ghost


            assigned     awarecan

      Mar 7, 2019

    

  



    

    

      
    

    


      

          @ghost
  ghost


          added
  the 

  in progress

 label


      Mar 7, 2019

    

  



    

    

      
    

    


      

          @awarecan
awarecan




          added this to the   0.89.1 milestone


      Mar 7, 2019

    

  








      

  
      



  

  @awarecan





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  
    

      

      
            awarecan
  

      

      

      commented


        Mar 7, 2019


      
    


  




      


        


  
    

      
          
In future, I hope that script can honor --log-no-color command line option

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @kellerza





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  
    

      

      
            kellerza
  

      

      

      commented


        Mar 7, 2019


      
    


  




      


        


  
    

      
          
This looks better!  --log-no-color was partially there with your fix. Or you should just mock out color of the script you load ;-) if you get that cmdline option

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @awarecan





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  
    

      

      
            awarecan
  

      

      

      commented


        Mar 7, 2019


      
    


  




      


        


  
    

      
          
Will not do that in this hot fix anyway

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        





      

  
          

  

    
  

  



        @balloob
  balloob



        merged commit 78a806b
      into

      
  
    home-assistant:dev
  


    Mar 8, 2019

  







    

    

      
    

    


      

          @ghost
  ghost


          removed
  the 

  in progress

 label


      Mar 8, 2019

    

  



    


  


  
    
  
  

    
  balloob 

      pushed a commit
      that referenced
      this pull request

    
      Mar 8, 2019
    
    

      


  

    

      


  

      
        @awarecan
      
        @balloob
  





      

        
          Fix script load module issue (#21763)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          c031fd4
        
      

    

  

    

      
* Fix script load depedency

* Revert #21754

    




    

  




  

  

    
  


  

      

    @balloob
balloob



    mentioned this pull request
    
      Mar 8, 2019
    





  


  

      
   Merged

  







  




  

  
  

  
      @awarecan
  awarecan


    
    deleted the
    
      
        fix-script-load-module-issue
    
    branch

    March 12, 2019 05:49    
    













  
  

    

      

  




      


    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    

  

    Reviewers
  


    


        

          

  
      @kellerza
  
    kellerza



          
            
              
            
          
          kellerza approved these changes

        


      






    

  


      
  

    Assignees
  



        

      

        

  
      @awarecan
  
    awarecan
    

      








      


  


  

    Labels
  



    

      

    cherry-picked

  

    cla-signed

  

    core

  

    small-pr

  PRs with less than 30 lines.








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    0.89.1
  





    
      
          


  

    

      
        

          
    

    Development
  



            


Successfully merging this pull request may close these issues.



  
  
  



      
    

  




      

    

  
      

  

    

      4 participants
    

    

        
          @awarecan 
        
          @kellerza 
        
          @balloob 
        
          @homeassistant 
    

  






    

    




    







  

    

  

  


    



  





    

  


  


          



    



  

    

    

    





    


    

    

  



0