add link ability to configurator #2035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at home-assistant/frontend#57 you expect the link attribute to be a hash? That will be quite unclear for users so let's just stick to two parameters, link_name, link_url |
|
updated to 2 attributes instead of a hash |
|
There are a bunch of commits in this PR that shouldn't be here. The code looks fine but I can't merge it like this. |
05707a4 to
cfac403
Compare
|
fixed |
|
Awesome! 🐬 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Not thrilled with this but unsure of what would be better. This allows the dev to construct his description in such a way to have it end with a link like the few components I looked at do anyway.
Related issue (if applicable): #
Example entry for
configuration.yaml(if applicable):Checklist:
If code communicates with devices:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass