Update __init__.py 8000 #19319
Closed
Update __init__.py #19319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we add : STATE_AUTO = 'auto' STATE_MANUAL = 'manual' We can use the same states for the heating (climate device) and water heater device since these are often combined in the same systems (atleast in europe/The netherlands). This will make it more user-friendly for our users that have this system combined The states are already included in Homeassistant so translations should work without an problem.
|
this is going to be hit by home-assistant/architecture#117 and home-assistant/architecture#22 |
|
Entity model changes needs approval in architecture issue before merging. |
|
@MartinHjelmare allright I will propose this in the architecture issue as well ;)! thanks |
|
This needs a better title. Maybe: "Add On and Manual states to water_heater component". In any case, I think merging this into #19093 may be a better idea? If you agree, would you be happy to close this PR and continue the discussion over there? |
|
@zxdavb I followed your advise and merged them together |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If we add :
STATE_AUTO = 'auto'
STATE_MANUAL = 'manual'
We can use the same states for the heating (climate device) and water heater device since these are often combined in the same systems (atleast in europe/The netherlands). This will make it more user-friendly for our users that have this system combined
The states are already included in Homeassistant so translations should work without an problem.
Checklist:
tox. Your PR cannot be merged unless tests pass