8000 Constant polling for Husqvarna Automower by Thomas55555 · Pull Request #147957 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Constant polling for Husqvarna Automower #147957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Constant polling for Husqvarna Automower #147957

wants to merge 5 commits into from
+87 −3

Conversation

Thomas55555
Copy link
Contributor

Breaking change

Proposed change

The built-in implementation of the update coordinator resets the polling timer on every websocket update. Since websockets do not deliver all required data (e.g. statistics or work area details), we enforce a constant REST polling cadence by overwriting the built async_set_updated_data method of the coordinator.
Please include in next patch release.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes Husqvarna Lawn Progress Refresh Rate #147932
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

edenhaus
edenhaus reviewed Jul 2, 2025
View reviewed changes
Copy link
Member
@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests for it?
So we make sure that the timer will not bet reseted even in the future

@frenck
Copy link
Member
frenck commented Jul 3, 2025

I've marked this PR a draft, as changes are requested that need to be processed.
Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

@frenck frenck marked this pull request as draft July 3, 2025 20:05
@Thomas55555 Thomas55555 marked this pull request as ready for review July 3, 2025 20:06
@Thomas55555
Copy link
Contributor Author
Thomas55555 commented Jul 3, 2025 •
edited
Loading

Thank you
I just added the test :)

@Thomas55555 Thomas55555 marked this pull request as draft July 3, 2025 20:14
@frenck
Copy link
Member
frenck commented Jul 3, 2025

Well they are not passing 😬

@Thomas55555
Copy link
Contributor Author
Thomas55555 commented Jul 3, 2025 •
edited
Loading

They were flakey. But now they work 👍

@Thomas55555 Thomas55555 marked this pull request as ready for review July 3, 2025 20:41
@frenck frenck requested a review from edenhaus July 3, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edenhaus edenhaus Awaiting requested review from edenhaus

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix by-code-owner cla-signed integration: husqvarna_automower Quality Scale: silver small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Husqvarna Lawn Progress Refresh Rate
3 participants
@Thomas55555 @frenck @edenhaus
0