8000 Replace dot with underscores for NamespacedTool and ActionTool by Shulyaka · Pull Request #147764 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace dot with underscores for NamespacedTool and ActionTool #147764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Shulyaka
8000 Copy link
Contributor
@Shulyaka Shulyaka commented Jun 29, 2025

Proposed change

Anthropic API requires that the tool name matches the ^[a-zA-Z0-9_-]{1,128}$ pattern. Currently NamespacedTool and ActionTool use dots int their name that violate the pattern. This PR replaces dots with double underscores.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Copilot Copilot AI review requested due to automatic review settings June 29, 2025 09:20
@Shulyaka Shulyaka requested a review from a team as a code owner June 29, 2025 09:20
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Jun 29, 2025
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that tool names conform to the Anthropic API naming requirements by replacing dots with underscores in the names of NamespacedTool and ActionTool.

  • Updated tool name composition in homeassistant/helpers/llm.py
  • Adjusted corresponding test expectations in tests/helpers/test_llm.py

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/helpers/test_llm.py Updated expected tool names in tests to use underscores instead of dots
homeassistant/helpers/llm.py Modified NamespacedTool and ActionTool to construct names with underscores

@Ramblurr
Copy link
Ramblurr commented Jun 30, 2025

Can I recommend a double underscore? That is at least how Anthropic does it in Claude Code.

In Claude Code the MCP tools are named like so: mcp__<namespace>__<toolname>:

Real examples:

  • mcp__clojure-mcp__clojure_edit

The benefit of a double underscore is that it still provides separation/delineation when a toolname or namespace name contains a single underscore.

@Shulyaka
Copy link
Contributor Author

Good point, I like it

@Shulyaka Shulyaka changed the title Replace dot with underscore for NamespacedTool and ActionTool Replace dot with underscores for NamespacedTool and ActionTool Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
2 participants
0